lkml.org 
[lkml]   [2017]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example
    From
    Date
    Hello Wolfram,

    On 04/19/2017 02:51 PM, Wolfram Sang wrote:
    > On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote:
    >> The example contains a device node for a retu device, but
    >> its compatible string doesn't have a vendor prefix.
    >>
    >> While being there, drop the -mfd suffix since isn't correct.
    >>
    >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
    >> Acked-by: Rob Herring <robh@kernel.org>
    >> Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
    >> Acked-by: Tony Lindgren <tony@atomide.com>
    >
    > Wouldn't it be nice if we fix the driver also so it actually matches the
    > below compatible? I can't find such a change in linux-next.
    >

    [snip]

    >>
    >> - retu-mfd: retu@1 {
    >> - compatible = "retu-mfd";
    >> + retu: retu@1 {
    >> + compatible = "nokia,retu";
    >> reg = <0x1>;
    >> };

    You mean having a "nokia,retu" entry in a OF table?

    That's done by patch 3/8 in this series:

    http://www.spinics.net/lists/devicetree/msg173145.html

    Best regards,
    --
    Javier Martinez Canillas
    Open Source Group
    Samsung Research America

    \
     
     \ /
      Last update: 2017-04-19 21:13    [W:3.239 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site