lkml.org 
[lkml]   [2017]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 14/21] PCI: designware: update PCI config space remap function
    Date
    PCI configuration space should be mapped with a memory region type that
    generates on the CPU host bus non-posted write transations. Update the
    driver to use the devm_pci_remap_cfg* interface to make sure the correct
    memory mappings for PCI configuration space are used.

    Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Cc: Bjorn Helgaas <bhelgaas@google.com>
    Cc: Jingoo Han <jingoohan1@gmail.com>
    Cc: Joao Pinto <Joao.Pinto@synopsys.com>
    ---
    drivers/pci/dwc/pcie-designware-host.c | 12 +++++++-----
    1 file changed, 7 insertions(+), 5 deletions(-)

    diff --git a/drivers/pci/dwc/pcie-designware-host.c b/drivers/pci/dwc/pcie-designware-host.c
    index 5ba3349..2b789af 100644
    --- a/drivers/pci/dwc/pcie-designware-host.c
    +++ b/drivers/pci/dwc/pcie-designware-host.c
    @@ -338,8 +338,9 @@ int dw_pcie_host_init(struct pcie_port *pp)
    }

    if (!pci->dbi_base) {
    - pci->dbi_base = devm_ioremap(dev, pp->cfg->start,
    - resource_size(pp->cfg));
    + pci->dbi_base = devm_pci_remap_cfgspace(dev,
    + pp->cfg->start,
    + resource_size(pp->cfg));
    if (!pci->dbi_base) {
    dev_err(dev, "error with ioremap\n");
    ret = -ENOMEM;
    @@ -350,8 +351,8 @@ int dw_pcie_host_init(struct pcie_port *pp)
    pp->mem_base = pp->mem->start;

    if (!pp->va_cfg0_base) {
    - pp->va_cfg0_base = devm_ioremap(dev, pp->cfg0_base,
    - pp->cfg0_size);
    + pp->va_cfg0_base = devm_pci_remap_cfgspace(dev,
    + pp->cfg0_base, pp->cfg0_size);
    if (!pp->va_cfg0_base) {
    dev_err(dev, "error with ioremap in function\n");
    ret = -ENOMEM;
    @@ -360,7 +361,8 @@ int dw_pcie_host_init(struct pcie_port *pp)
    }

    if (!pp->va_cfg1_base) {
    - pp->va_cfg1_base = devm_ioremap(dev, pp->cfg1_base,
    + pp->va_cfg1_base = devm_pci_remap_cfgspace(dev,
    + pp->cfg1_base,
    pp->cfg1_size);
    if (!pp->va_cfg1_base) {
    dev_err(dev, "error with ioremap\n");
    --
    2.10.0
    \
     
     \ /
      Last update: 2017-04-19 18:50    [W:4.702 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site