Messages in this thread | | | Date | Wed, 19 Apr 2017 22:28:12 +0800 | From | Leo Yan <> | Subject | Re: [PATCH v6 6/8] coresight: add support for CPU debug module |
| |
Hi Suzuki,
On Wed, Apr 19, 2017 at 02:23:04PM +0100, Suzuki K Poulose wrote: > Hi Leo, > > This version looks good to me. I have two minor comments below.
Thanks for reviewing. Will take the suggestions. Just check a bit for last comment.
[...]
> >+static int debug_probe(struct amba_device *adev, const struct amba_id *id) > >+{ > >+ void __iomem *base; > >+ struct device *dev = &adev->dev; > >+ struct debug_drvdata *drvdata; > >+ struct resource *res = &adev->res; > >+ struct device_node *np = adev->dev.of_node; > >+ int ret; > >+ > >+ drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > >+ if (!drvdata) > >+ return -ENOMEM; > >+ > >+ drvdata->cpu = np ? of_coresight_get_cpu(np) : 0; > >+ if (per_cpu(debug_drvdata, drvdata->cpu)) { > >+ dev_err(dev, "CPU%d drvdata has been initialized\n", > >+ drvdata->cpu); > > May be we could warn about a possible issue in the DT ?
So can I understand the suggestion is to add warning in function of_coresight_get_cpu() when cannot find CPU number, and here directly bail out?
Thanks, Leo Yan
| |