Messages in this thread | | | Subject | Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio mode | From | "Jin, Yao" <> | Date | Wed, 19 Apr 2017 12:11:49 +0800 |
| |
On 4/19/2017 8:53 AM, Jin, Yao wrote: > > > On 4/19/2017 2:53 AM, Jiri Olsa wrote: >> On Wed, Apr 12, 2017 at 06:21:05AM +0800, Jin Yao wrote: >> >> SNIP >> >>> +const char *branch_type_name(int type) >>> +{ >>> + const char *branch_names[PERF_BR_MAX] = { >>> + "N/A", >>> + "JCC", >>> + "JMP", >>> + "IND_JMP", >>> + "CALL", >>> + "IND_CALL", >>> + "RET", >>> + "SYSCALL", >>> + "SYSRET", >>> + "IRQ", >>> + "INT", >>> + "IRET", >>> + "FAR_BRANCH", >>> + }; >>> + >>> + if ((type >= 0) && (type < PERF_BR_MAX)) >>> + return branch_names[type]; >>> + >>> + return NULL; >> looks like we should add util/branch.c with above functions >> and merge it with util/parse-branch-options.c >> >> we create new file even for less code ;-) >> >> thanks, >> jirka > > Could we directly add branch_type_name() in util/parse-branch-options.c? > > I just feel it's a bit waste of creating a new file for less code. :) > > Thanks > Jin Yao
After considering again, yes, creating util/branch.c should be better. I will do that.
Thanks Jin Yao
| |