Messages in this thread | | | Subject | Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line | From | Krzysztof Opasiak <> | Date | Wed, 19 Apr 2017 10:45:43 +0200 |
| |
On 04/15/2017 03:35 AM, Stefan Agner wrote: > Other unsigned properties return hexadecimal values, follow this > convention when printing b_vendor_code too. Also add newlines to > the OS Descriptor support related properties, like other sysfs > files use. > > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > drivers/usb/gadget/configfs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c > index 863ca4ded1be..a22a892de7b7 100644 > --- a/drivers/usb/gadget/configfs.c > +++ b/drivers/usb/gadget/configfs.c > @@ -738,7 +738,7 @@ static inline struct gadget_info *os_desc_item_to_gadget_info( > > static ssize_t os_desc_use_show(struct config_item *item, char *page) > { > - return sprintf(page, "%d", > + return sprintf(page, "%d\n", > os_desc_item_to_gadget_info(item)->use_os_desc); > } > > @@ -762,7 +762,7 @@ static ssize_t os_desc_use_store(struct config_item *item, const char *page, > > static ssize_t os_desc_b_vendor_code_show(struct config_item *item, char *page) > { > - return sprintf(page, "%d", > + return sprintf(page, "0x%02x\n", > os_desc_item_to_gadget_info(item)->b_vendor_code); > } > > @@ -904,7 +904,7 @@ static inline struct usb_os_desc_ext_prop > > static ssize_t ext_prop_type_show(struct config_item *item, char *page) > { > - return sprintf(page, "%d", to_usb_os_desc_ext_prop(item)->type); > + return sprintf(page, "%d\n", to_usb_os_desc_ext_prop(item)->type); > } > > static ssize_t ext_prop_type_store(struct config_item *item, > looks good to me:
Reviewed-by: Krzysztof Opasiak <k.opasiak@samsung.com> -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics
| |