Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 20 Apr 2017 00:15:30 +0200 | Subject | Re: [PATCH] [media] rainshadow-cec: use strlcat instead of strncat |
| |
On Wed, Apr 19, 2017 at 11:14 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote: > On 19/04/17 19:15, Arnd Bergmann wrote: >> gcc warns about an obviously incorrect use of strncat(): >> >> drivers/media/usb/rainshadow-cec/rainshadow-cec.c: In function 'rain_cec_adap_transmit': >> drivers/media/usb/rainshadow-cec/rainshadow-cec.c:299:4: error: specified bound 48 equals the size of the destination [-Werror=stringop-overflow=] >> >> It seems that strlcat was intended here, and using that makes the >> code correct. > > Oops! You're right, it should be strlcat. > > Which gcc version do you use? Mine (6.3.0) didn't give an error (or warning, for that matter).
I think the warning was only added in gcc-7.0.1.
Arnd
| |