lkml.org 
[lkml]   [2017]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] [media] sti: hdmi: improve MEDIA_CEC_NOTIFIER dependency
    From
    Date
    Hi Arnd,

    On 19/04/17 18:59, Arnd Bergmann wrote:
    > When the media subsystem is built as a loadable module, a built-in
    > DRM driver cannot use the cec notifiers:
    >
    > drivers/gpu/drm/sti/sti_hdmi.o: In function `sti_hdmi_remove':
    > sti_hdmi.c:(.text.sti_hdmi_remove+0x28): undefined reference to `cec_notifier_set_phys_addr'
    > sti_hdmi.c:(.text.sti_hdmi_remove+0x50): undefined reference to `cec_notifier_put'
    > drivers/gpu/drm/sti/sti_hdmi.o: In function `sti_hdmi_connector_get_modes':
    > sti_hdmi.c:(.text.sti_hdmi_connector_get_modes+0x84): undefined reference to `cec_notifier_set_phys_addr_from_edid'
    > drivers/gpu/drm/sti/sti_hdmi.o: In function `sti_hdmi_probe':
    > sti_hdmi.c:(.text.sti_hdmi_probe+0x1a8): undefined reference to `cec_notifier_get'
    > drivers/gpu/drm/sti/sti_hdmi.o: In function `sti_hdmi_connector_detect':
    > sti_hdmi.c:(.text.sti_hdmi_connector_detect+0x68): undefined reference to `cec_notifier_set_phys_addr'
    > drivers/gpu/drm/sti/sti_hdmi.o: In function `sti_hdmi_disable':
    > sti_hdmi.c:(.text.sti_hdmi_disable+0xec): undefined reference to `cec_notifier_set_phys_addr'
    >
    > This adds a Kconfig dependency to enforce the HDMI driver to also
    > be a loadable module in this case.

    I've marked this patch and the exynos_hdmi patch as 'Obsoleted' in patchwork:
    today several CEC Kconfig cleanup patches were merged that invalidate these
    two patches. I expect they'll turn up soon in -next.

    Regards,

    Hans

    >
    > Fixes: bca55958ea87 ("[media] sti: hdmi: add CEC notifier support")
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > ---
    > drivers/gpu/drm/sti/Kconfig | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig
    > index acd72865feac..adac4c3e142e 100644
    > --- a/drivers/gpu/drm/sti/Kconfig
    > +++ b/drivers/gpu/drm/sti/Kconfig
    > @@ -1,6 +1,7 @@
    > config DRM_STI
    > tristate "DRM Support for STMicroelectronics SoC stiH4xx Series"
    > depends on DRM && (ARCH_STI || ARCH_MULTIPLATFORM)
    > + depends on (MEDIA_SUPPORT && MEDIA_CEC_NOTIFIER) || !MEDIA_CEC_NOTIFIER
    > select RESET_CONTROLLER
    > select DRM_KMS_HELPER
    > select DRM_GEM_CMA_HELPER
    >

    \
     
     \ /
      Last update: 2017-04-19 23:07    [W:3.771 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site