Messages in this thread | | | From | Eric Anholt <> | Subject | Re: [PATCH 1/3 v2] drm/vc4: Turn the V3D clock on at runtime. | Date | Tue, 18 Apr 2017 17:02:33 -0700 |
| |
Florian Fainelli <f.fainelli@gmail.com> writes:
> On 04/18/2017 04:38 PM, Eric Anholt wrote: >> For the Raspberry Pi's bindings, the power domain also implicitly >> turns on the clock and deasserts reset, but for the new Cygnus port we >> start representing the clock in the devicetree. >> >> v2: Document the clock-names property, check for -ENOENT for no clock >> in DT. >> >> Signed-off-by: Eric Anholt <eric@anholt.net> >> --- > >> + if (v3d->clk) >> + clk_disable_unprepare(v3d->clk); > > The clock API allows you to pass a NULL clk and do nothing in these > cases which is what you seem to have done a few lines below, you could > simplify these checks?
Sounds good. [unhandled content-type:application/pgp-signature] | |