lkml.org 
[lkml]   [2017]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 tip/core/rcu 05/39] rcu: Semicolon inside RCU_TRACE() for rcu.h
    Date
    The current use of "RCU_TRACE(statement);" can cause odd bugs, especially
    where "statement" is a local-variable declaration, as it can leave a
    misplaced ";" in the source code. This commit therefore converts these
    to "RCU_TRACE(statement;)", which avoids the misplaced ";".

    Reported-by: Josh Triplett <josh@joshtriplett.org>
    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    ---
    kernel/rcu/rcu.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/kernel/rcu/rcu.h b/kernel/rcu/rcu.h
    index 0d6ff3e471be..8700a81daf56 100644
    --- a/kernel/rcu/rcu.h
    +++ b/kernel/rcu/rcu.h
    @@ -109,12 +109,12 @@ static inline bool __rcu_reclaim(const char *rn, struct rcu_head *head)

    rcu_lock_acquire(&rcu_callback_map);
    if (__is_kfree_rcu_offset(offset)) {
    - RCU_TRACE(trace_rcu_invoke_kfree_callback(rn, head, offset));
    + RCU_TRACE(trace_rcu_invoke_kfree_callback(rn, head, offset);)
    kfree((void *)head - offset);
    rcu_lock_release(&rcu_callback_map);
    return true;
    } else {
    - RCU_TRACE(trace_rcu_invoke_callback(rn, head));
    + RCU_TRACE(trace_rcu_invoke_callback(rn, head);)
    head->func(head);
    rcu_lock_release(&rcu_callback_map);
    return false;
    --
    2.5.2
    \
     
     \ /
      Last update: 2017-04-18 01:47    [W:3.840 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site