lkml.org 
[lkml]   [2017]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: iio: light: constify attribute_group structures
From
Date
On 01/04/17 03:28, simran singhal wrote:
> As the event_attrs field of iio_info structures is constant, so these
> attribute_group structures can also be declared constant.
>
> File size before:
> text data bss dec hex filename
> 15064 1528 0 16592 40d0
> drivers/staging/iio/light/tsl2x7x_core.o
>
> File size after:
> text data bss dec hex filename
> 15192 1400 0 16592 40d0
> drivers/staging/iio/light/tsl2x7x_core.o
>
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Not a big thing, but as this only touches the one driver, i would have
liked that mentioned in the naming of the patch...

I've added it.
Applied.
> ---
> drivers/staging/iio/light/tsl2x7x_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
> index 0490c1d..9a0046a 100644
> --- a/drivers/staging/iio/light/tsl2x7x_core.c
> +++ b/drivers/staging/iio/light/tsl2x7x_core.c
> @@ -1676,7 +1676,7 @@ static const struct attribute_group tsl2X7X_device_attr_group_tbl[] = {
> },
> };
>
> -static struct attribute_group tsl2X7X_event_attr_group_tbl[] = {
> +static const struct attribute_group tsl2X7X_event_attr_group_tbl[] = {
> [ALS] = {
> .attrs = tsl2X7X_ALS_event_attrs,
> .name = "events",
>

\
 
 \ /
  Last update: 2017-04-01 12:41    [W:0.043 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site