lkml.org 
[lkml]   [2017]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] iio: magnetometer: ak8974: remove incorrect __exit markups
From
Date
On 01/03/17 23:37, Dmitry Torokhov wrote:
> Even if bus is not hot-pluggable, devices can be unbound from the
> driver via sysfs, so we should not be using __exit annotations on
> remove() methods. The only exception is drivers registered with
> platform_driver_probe() which specifically disables sysfs bind/unbind
> attributes.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks,

Applied to the fixes-togreg branch of iio.git and marked for stable.

Jonathan
> ---
> drivers/iio/magnetometer/ak8974.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/ak8974.c b/drivers/iio/magnetometer/ak8974.c
> index ce09d771c1fb..75f83424903b 100644
> --- a/drivers/iio/magnetometer/ak8974.c
> +++ b/drivers/iio/magnetometer/ak8974.c
> @@ -767,7 +767,7 @@ static int ak8974_probe(struct i2c_client *i2c,
> return ret;
> }
>
> -static int __exit ak8974_remove(struct i2c_client *i2c)
> +static int ak8974_remove(struct i2c_client *i2c)
> {
> struct iio_dev *indio_dev = i2c_get_clientdata(i2c);
> struct ak8974 *ak8974 = iio_priv(indio_dev);
> @@ -849,7 +849,7 @@ static struct i2c_driver ak8974_driver = {
> .of_match_table = of_match_ptr(ak8974_of_match),
> },
> .probe = ak8974_probe,
> - .remove = __exit_p(ak8974_remove),
> + .remove = ak8974_remove,
> .id_table = ak8974_id,
> };
> module_i2c_driver(ak8974_driver);
>

\
 
 \ /
  Last update: 2017-03-05 12:30    [W:0.047 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site