lkml.org 
[lkml]   [2017]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Outreachy kernel] [PATCH] staging: media: Remove unnecessary function and its call
From
Date
On Sun, 2017-03-05 at 10:14 -0800, Alison Schofield wrote:
> On Sun, Mar 05, 2017 at 12:17:21PM +0530, simran singhal wrote:
> > The function atomisp_set_stop_timeout on being called, simply returns
> > back. The function hasn't been mentioned in the TODO and doesn't have
> > FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been
> > removed.
> >
> > Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> > ---
>
> Hi Simran,
>
> It's helpful to state right in the subject line what you removed.
> ie. remove unused function atomisp_set_stop_timeout()
>
> If you do that, scan's or grep'ing the git log pretty oneline's can
> easily see this without having to dig into the log.
>
> (gitpretty='git log --pretty=oneline --abbrev-commit')
>
> Can you share to Outreachy group how you found this? By inspection
> or otherwise??

At least for the rtl8192u patch submitted:

It's also helpful to read the comment you remove
and determine if what you are doing is the correct
thing to do and explain why it's OK in the commit
message. (fractured english below notwithstanding)

/* These function were added to load crypte module autoly */
- ieee80211_tkip_null();


\
 
 \ /
  Last update: 2017-03-05 19:55    [W:0.056 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site