Messages in this thread | | | From | Tomasz Figa <> | Date | Sat, 4 Mar 2017 20:20:11 +0900 | Subject | Re: [PATCH v2] pinctrl: samsung: Calculate GPIO base for pinctrl_add_gpio_range |
| |
Hi Charles,
2017-03-01 2:04 GMT+09:00 Charles Keepax <ckeepax@opensource.wolfsonmicro.com>: > As the pinctrl is now added before the GPIOs are registered we need to > manually calculate what the GPIO base will be, otherwise the base for > each gpio_range will be set to zero. Fortunately the driver > already assigns a GPIO base, in samsung_gpiolib_register, and uses the > same calculation it does for the pin_base. Meaning the two will always > be the same and allowing us to reuse the pinbase and avoid the issue.
Sorry, I didn't notice before and I don't see the offending patch in , but you should add
Fixes: XXXXXXXXXXXX ("pinctrl: Patch subject")
if you intend to submit this patch separately. Otherwise, maybe this can be just squashed?
> > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > --- > > Changes since v1: > - Use grange.base in samsung_gpiolib_register to make it more > clear the two are related in the driver.
Other than the above:
Acked-by: Tomasz Figa <tomasz.figa@gmail.com>
Best regards, Tomasz
| |