lkml.org 
[lkml]   [2017]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH] ALSA: hda/ca0132: Limit values for chip addresses to 32-bit
Sorry for the delayed reply,

El Mon, Mar 20, 2017 at 10:33:43AM +0100 Takashi Iwai ha dit:

> On Thu, 16 Mar 2017 21:52:23 +0100,
> Matthias Kaehlcke wrote:
> >
> > With the previous unsigned long value clang generates warnings like
> > this:
> >
> > sound/pci/hda/patch_ca0132.c:860:37: error: implicit conversion from
> > 'unsigned long' to 'u32' (aka 'unsigned int') changes value from
> > 18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion]
> > spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx;
> > ~ ^~~~
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>
> Thanks for the patch. The changes look mostly OK, but...
>
> > ---
> > sound/pci/hda/patch_ca0132.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
> > index 11b9b2f17a2e..7175e2b46fc4 100644
> > --- a/sound/pci/hda/patch_ca0132.c
> > +++ b/sound/pci/hda/patch_ca0132.c
> > @@ -857,7 +857,7 @@ static int chipio_write_address(struct hda_codec *codec,
> > chip_addx >> 16);
> > }
> >
> > - spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx;
> > + spec->curr_chip_addx = (res < 0) ? (u32)~0U : chip_addx;
>
> ... I guess the cast to u32 is superfluous here? That is, just
> replace UL to U should work, I suppose. (Ditto for all other places.)

You are right, the cast is not needed. I'll send an updated version.

Cheers

Matthias

\
 
 \ /
  Last update: 2017-04-01 02:53    [W:0.070 / U:0.964 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site