lkml.org 
[lkml]   [2017]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] zram: factor out partial IO routine
Hello,

On (03/31/17 08:33), Minchan Kim wrote:
[..]
> > a bigger side effect is that now we double the amount of lines we need
> > to change in certain patches and, thus, the amount of work - when we
> > add new functionality/fix something in zram_bvec_{write, read} we also
> > would need to touch zram_bvec_partial_{write, read}.
>
> Yes, that is a pain, too. However, I thought it would be more easier
> because as-is partial IO routine is more error-prone to me. :)

yeah, it is quite tricky and a bit difficult. agree.

> > still probably worth it.
> >
> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>
> Thanks for the review.
> so I tried clean-up further to make you happy. :)
>
> How about this?
> It's totally untested and I have no time until Monday next week.
> So, please review with having enough time.

will take a look :)
thanks!

-ss

\
 
 \ /
  Last update: 2017-03-31 06:06    [W:0.034 / U:2.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site