lkml.org 
[lkml]   [2017]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCHv2 4/8] pm: switch to printk.emergency mode in unsafe places
On Wed 2017-03-29 18:25:07, Sergey Senozhatsky wrote:
> It's not always possible/safe to wake_up() printk kernel
> thread. For example, late suspend/early resume may printk()
> while timekeeping is not initialized yet, so calling into the
> scheduler may result in recursive warnings.
>
> Another thing to notice is the fact PM at some point
> freezes user space and kernel threads: freeze_processes()
> and freeze_kernel_threads(), correspondingly. Thus we need
> printk() to operate in old mode there and attempt to
> immediately flush pending kernel message to the console.
>
> This patch adds printk_emergency_begin/on sections.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

It looks reasonable to me. Feel free to use:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Well, it still would be great if people more familiar
with this code look at it.

Best Regards,
Petr

\
 
 \ /
  Last update: 2017-03-31 17:07    [W:0.409 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site