lkml.org 
[lkml]   [2017]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] serial: tegra: Map the iir register to default defines
Date
> On 31/03/17 11:07, Shardar Mohammed wrote:
> > Verification failed on Tegra.
> > Fix here is, IIR should be masked with UART_IIR_MASK after reading the IIR
> register as on Tegra bit-6 is used for internal usage to know if FIFO mode is
> enabled.
> > while (1) {
> > iir = tegra_uart_read(tup, UART_IIR);
> > +iir &= UART_IIR_MASK;
>
> Per Olliver's original email did you pick up the other patch [0] before applying
> this because that does apply the mask. I mentioned to Olliver that this should
> really be a series, so it is clear that this patch is dependent upon the other.

For UART_IIR_MASK macro, dependent patch is required if we add this required line.
But here to fix the issue with the current patch above masking step is necessary.

>
> > -----Original Message-----
> > From: Laxman Dewangan
> > Sent: Thursday, March 30, 2017 3:48 PM
> > To: Olliver Schinagl <oliver@schinagl.nl>; Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org>; Jiri Slaby <jslaby@suse.com>; Stephen
> > Warren <swarren@wwwdotorg.org>; Thierry Reding
> > <thierry.reding@gmail.com>; Alexandre Courbot <gnurou@gmail.com>
> > Cc: linux-serial@vger.kernel.org; linux-tegra@vger.kernel.org;
> > linux-kernel@vger.kernel.org; Shardar Mohammed
> <smohammed@nvidia.com>
> > Subject: Re: [PATCH] serial: tegra: Map the iir register to default
> > defines
> >
> >
> > On Thursday 30 March 2017 12:18 AM, Olliver Schinagl wrote:
> >> The tegra serial IP seems to be following the common layout and the
> >> interrupt ID's match up nicely. Replace the magic values to match the
> >> common serial_reg defines, with the addition of the Tegra unique End
> >> of Data interrupt.
> >>
> >> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> >> ---
> >
> > Adding Shardar for verifications.
> >
> > Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
>
> Furthermore does this ACK imply that you have reviewed the other patch this
> one is dependent upon?
>
Yes dependent change looks fine, but I have not tested it.

> Cheers
> Jon
>
> [0] http://marc.info/?l=linux-serial&m=149081309627392&w=2
>
> --
> nvpublic

\
 
 \ /
  Last update: 2017-03-31 12:46    [W:0.065 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site