lkml.org 
[lkml]   [2017]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] mfd: stmpe: Fix bit clearing on STMPE1600
Date
Hi Hugues

On 03/31/2017 10:12 AM, Hugues Fruchet wrote:
> GPIO bits clearing on pins assigned to STMPE1600
> had no effects due to missing "clear registers"
> settings within stmpe1600_regs[].
> STMPE1600 does not have dedicated "clear registers",
> but single "set/clear registers", hence stmpe1600_regs[]
> "clear registers" (STMPE_IDX_GPCR_XXX) must be set to
> same value as "set registers" (STMPE_IDX_GPSR_XXX), ie
> STMPE1600_REG_GPSR_XXX.
>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
> ---
> drivers/mfd/stmpe.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index b0c7bcd..566caca 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -568,6 +568,8 @@ static int stmpe811_get_altfunc(struct stmpe *stmpe, enum stmpe_block block)
> [STMPE_IDX_GPMR_CSB] = STMPE1600_REG_GPMR_MSB,
> [STMPE_IDX_GPSR_LSB] = STMPE1600_REG_GPSR_LSB,
> [STMPE_IDX_GPSR_CSB] = STMPE1600_REG_GPSR_MSB,
> + [STMPE_IDX_GPCR_LSB] = STMPE1600_REG_GPSR_LSB,
> + [STMPE_IDX_GPCR_CSB] = STMPE1600_REG_GPSR_MSB,
> [STMPE_IDX_GPDR_LSB] = STMPE1600_REG_GPDR_LSB,
> [STMPE_IDX_GPDR_CSB] = STMPE1600_REG_GPDR_MSB,
> [STMPE_IDX_IEGPIOR_LSB] = STMPE1600_REG_IEGPIOR_LSB,
>

Reviewed-by: Patrice Chotard <patrice.chotard@st.com>

Thanks

\
 
 \ /
  Last update: 2017-03-31 11:19    [W:0.036 / U:1.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site