lkml.org 
[lkml]   [2017]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 13/37] mtd: nand: denali: avoid hard-coding ecc.strength and ecc.bytes
On Thu, 30 Mar 2017 15:45:59 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

>
> diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c
> index 1681a30..c3bc333 100644
> --- a/drivers/mtd/nand/denali_dt.c
> +++ b/drivers/mtd/nand/denali_dt.c
> @@ -31,10 +31,12 @@ struct denali_dt {
>
> struct denali_dt_data {
> unsigned int revision;
> + unsigned long ecc_strength_avail;

Shouldn't you directly make sure that your driver will support
strengths > BITS_PER_LONG?
I would store the supported strength in a table to make it more
future-proof:

int *ecc_strength_avail;
int num_ecc_strengths;


> unsigned int caps;
> };
>


\
 
 \ /
  Last update: 2017-03-31 11:10    [W:0.192 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site