lkml.org 
[lkml]   [2017]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/6] scsi: hisi_sas: remove the SAS host after the SCSI host
    Date
    After commit bcdde7e ("sysfs: make __sysfs_remove_dir() recursive") changed the
    removal path of kernfs to make it recursive we have to remove the SAS host
    before the SCSI host or we will see sysfs warnings on not found sysfs groups for
    kobjects.

    Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
    ---
    drivers/scsi/hisi_sas/hisi_sas_main.c | 10 ++++++++--
    1 file changed, 8 insertions(+), 2 deletions(-)

    diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
    index 53637a9..34476c2 100644
    --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
    +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
    @@ -1582,10 +1582,16 @@ int hisi_sas_remove(struct platform_device *pdev)
    struct sas_ha_struct *sha = platform_get_drvdata(pdev);
    struct hisi_hba *hisi_hba = sha->lldd_ha;
    struct Scsi_Host *shost = sha->core.shost;
    + unsigned long flags;
    +
    + spin_lock_irqsave(shost->host_lock, flags);
    + if (scsi_host_set_state(shost, SHOST_CANCEL))
    + WARN_ON(scsi_host_set_state(shost, SHOST_CANCEL_RECOVERY));
    + spin_unlock_irqrestore(shost->host_lock, flags);

    - scsi_remove_host(sha->core.shost);
    sas_unregister_ha(sha);
    - sas_remove_host(sha->core.shost);
    + sas_remove_host(shost);
    + scsi_remove_host(shost);

    hisi_sas_free(hisi_hba);
    kfree(shost);
    --
    1.8.5.6
    \
     
     \ /
      Last update: 2017-03-29 11:44    [W:4.108 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site