Messages in this thread | | | Date | Wed, 29 Mar 2017 09:32:42 +0200 | From | Greg KH <> | Subject | Re: [PATCHv2] staging: wlan-ng: fix avoid multiple line dereference warning reported by checkpatch.pl |
| |
On Sun, Mar 12, 2017 at 05:30:09PM +0200, Andrii wrote: > Fixed three code style warnings (multiple line dereference) reported > by checkpatch.pl script. > > Signed-off-by: Andrii Vladyka <tulup@mail.ru> > diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c > index 6134eba..a050748 100644 > --- a/drivers/staging/wlan-ng/hfa384x_usb.c > +++ b/drivers/staging/wlan-ng/hfa384x_usb.c > @@ -1346,14 +1346,8 @@ hfa384x_docmd(struct hfa384x *hw, > } else if (mode == DOWAIT) { > struct usbctlx_cmd_completor completor; > > - result = > - hfa384x_usbctlx_complete_sync(hw, ctlx, > - init_cmd_completor(&completor, > - &ctlx-> > - inbuf. > - cmdresp, > - &cmd-> > - result)); > + result = hfa384x_usbctlx_complete_sync(hw, ctlx, > + init_cmd_completor(&completor, &ctlx->inbuf.cmdresp, &cmd->result))
Ick, no, that doesn't look right, does it?
Please use your brain when making checkpatch changes, it's just a dumb perl script...
greg k-h
| |