lkml.org 
[lkml]   [2017]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 0/3] perf/sdt: Hardening argument support
Hi Arnaldo,

please pull this, I've already acked to this series.

Thank you,

On Tue, 28 Mar 2017 15:17:51 +0530
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:

> SDT event argument support on x86 is recently added to Perf. But
> there are couple of issues with it.
>
> It lacks renaming mapping for few 8 bit registers: al, bl, cl, dl,
> ah, bh, ch and dh. SDT events using these registers in arguments
> are failing at 'perf probe'. Add renaming logic to them. (patch 1)
>
> It still has x86 specific code in general code. It also fails to
> convert arguments having no offset but still surrounds register with
> parenthesis for ex. 8@(%rdi) is converted to +(%di):u64, which is
> rejected by uprobe_events. Also, 'perf probe' is failing for *all SDT
> events on all archs except x86*. Solve these issues. (patch 2)
>
> Add argument parser for powerpc. (patch 3)
>
> Changes in v3:
> - (patch 1) Add renaming entries for ah, bh, ch and dh registers.[1]
>
> - (patch 1) v2 contains silly copy-paste error. It maps all al, bl...
> registers to ax. Fix that.
>
> - (patch 2) Fix typo 'constant'.
>
> - Patch 2 is not applying cleanly on top of patch 1 after adding
> ah, bh... registers. Fix that.
>
> v2: https://lkml.org/lkml/2017/3/27/118
>
> This patch is prepared on top of acme/perf/core.
>
> [1] https://lkml.org/lkml/2017/3/27/462
>
> Ravi Bangoria (3):
> perf/sdt/x86: Add renaming logic for (missing) 8 bit registers
> perf/sdt/x86: Move OP parser to tools/perf/arch/x86/
> perf/sdt/powerpc: Add argument support
>
> tools/perf/arch/powerpc/util/perf_regs.c | 111 ++++++++++++++++++
> tools/perf/arch/x86/util/perf_regs.c | 187 +++++++++++++++++++++++++------
> tools/perf/util/perf_regs.c | 6 +-
> tools/perf/util/perf_regs.h | 11 +-
> tools/perf/util/probe-file.c | 132 +++++++---------------
> 5 files changed, 313 insertions(+), 134 deletions(-)
>
> --
> 2.9.3
>


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2017-03-28 17:30    [W:0.107 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site