lkml.org 
[lkml]   [2017]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] aspeed-lpc-ctrl: include linux/types.h for uapi header
On Wed, Mar 29, 2017 at 12:40 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added header file triggers a sanity check:
>
> usr/include/linux/aspeed-lpc-ctrl.h:44: found __[us]{8,16,32,64} type without #include <linux/types.h>

Thanks Arnd.

What tool are you running to do this check?

> We should include linux/types.h explicitly to ensure the header
> can be included from user space.
>
> Fixes: 6c4e97678501 ("drivers/misc: Add Aspeed LPC control driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Joel Stanley <joel@jms.id.au>

Cheers,

Joel

> ---
> include/uapi/linux/aspeed-lpc-ctrl.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/aspeed-lpc-ctrl.h b/include/uapi/linux/aspeed-lpc-ctrl.h
> index f96fa995a3f0..c328c976c684 100644
> --- a/include/uapi/linux/aspeed-lpc-ctrl.h
> +++ b/include/uapi/linux/aspeed-lpc-ctrl.h
> @@ -11,6 +11,7 @@
> #define _UAPI_LINUX_ASPEED_LPC_CTRL_H
>
> #include <linux/ioctl.h>
> +#include <linux/types.h>
>
> /* Window types */
> #define ASPEED_LPC_CTRL_WINDOW_FLASH 1
> --
> 2.9.0
>

\
 
 \ /
  Last update: 2017-03-28 16:21    [W:0.033 / U:1.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site