lkml.org 
[lkml]   [2017]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 30/76] USB: lvtest: fix NULL-deref at probe
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit 1dc56c52d2484be09c7398a5207d6b11a4256be9 upstream.

    Make sure to check the number of endpoints to avoid dereferencing a
    NULL-pointer should the probed device lack endpoints.

    Note that this driver does not bind to any devices by default.

    Fixes: ce21bfe603b3 ("USB: Add LVS Test device driver")
    Cc: Pratyush Anand <pratyush.anand@gmail.com>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/misc/lvstest.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/usb/misc/lvstest.c
    +++ b/drivers/usb/misc/lvstest.c
    @@ -370,6 +370,10 @@ static int lvs_rh_probe(struct usb_inter

    hdev = interface_to_usbdev(intf);
    desc = intf->cur_altsetting;
    +
    + if (desc->desc.bNumEndpoints < 1)
    + return -ENODEV;
    +
    endpoint = &desc->endpoint[0].desc;

    /* valid only for SS root hub */

    \
     
     \ /
      Last update: 2017-03-28 16:02    [W:5.774 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site