lkml.org 
[lkml]   [2017]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.10 030/111] Input: iforce - validate number of endpoints before using them
    Date
    4.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit 59cf8bed44a79ec42303151dd014fdb6434254bb upstream.

    Make sure to check the number of endpoints to avoid dereferencing a
    NULL-pointer or accessing memory that lie beyond the end of the endpoint
    array should a malicious device lack the expected endpoints.

    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/input/joystick/iforce/iforce-usb.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/input/joystick/iforce/iforce-usb.c
    +++ b/drivers/input/joystick/iforce/iforce-usb.c
    @@ -141,6 +141,9 @@ static int iforce_usb_probe(struct usb_i

    interface = intf->cur_altsetting;

    + if (interface->desc.bNumEndpoints < 2)
    + return -ENODEV;
    +
    epirq = &interface->endpoint[0].desc;
    epout = &interface->endpoint[1].desc;


    \
     
     \ /
      Last update: 2017-03-28 14:39    [W:3.176 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site