lkml.org 
[lkml]   [2017]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] KVM: x86: cleanup the page tracking SRCU instance
From
Date


On 28/03/2017 5:40 PM, Paolo Bonzini wrote:

> void kvm_page_track_init(struct kvm *kvm)
> {
> struct kvm_page_track_notifier_head *head;
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 64697fe475c3..f2379673912a 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -8070,6 +8070,7 @@ void kvm_arch_sync_events(struct kvm *kvm)
> cancel_delayed_work_sync(&kvm->arch.kvmclock_update_work);
> kvm_free_all_assigned_devices(kvm);
> kvm_free_pit(kvm);
> + kvm_page_track_cleanup(kvm);
> }

Moving it to kvm_arch_destroy_vm() is better as the init
function is called in kvm_arch_init_vm().

Otherwise it looks great to me:
Reviewed-by: Xiao Guangrong <xiaoguangrong.eric@gmail.com>

Thanks for the fix.

\
 
 \ /
  Last update: 2017-03-28 13:30    [W:0.047 / U:3.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site