Messages in this thread | | | From | Ming Lei <> | Date | Tue, 28 Mar 2017 18:44:43 +0800 | Subject | Re: [PATCH] Revert "md: raid1: use bio helper in process_checks()" |
| |
On Tue, Mar 28, 2017 at 5:49 PM, Arnd Bergmann <arnd@arndb.de> wrote: > Commit 60928a91b0b3 ("md: raid1: use bio helper in process_checks()") > is probably correct, but I get a new compile-time warning after > it, and have trouble understanding what it fixes: > > drivers/md/raid1.c: In function 'sync_request_write': > drivers/md/raid1.c:2172:9: error: 'page_len$' may be used uninitialized in this function [-Werror=maybe-uninitialized] > if (memcmp(page_address(ppages[j]), > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > page_address(spages[j]), > ~~~~~~~~~~~~~~~~~~~~~~~~ > page_len[j])) > ~~~~~~~~~~~~ > drivers/md/raid1.c:2160:7: note: 'page_len$' was declared here > int page_len[RESYNC_PAGES]; > ^~~~~~~~ > > This reverts it to resolve the warning.
Please try the following patch:
https://lkml.org/lkml/2017/3/28/126
BTW, the compile failure is just a false positive.
Thanks, Ming
| |