Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 28 Mar 2017 12:15:32 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/3] asm-generic, x86: wrap atomic operations |
| |
* Dmitry Vyukov <dvyukov@google.com> wrote:
> > So I'm not convinced that it's true in this case. > > > > Could we see the C version and compare? I could be wrong about it all. > > Here it is (without instrumentation): > https://gist.github.com/dvyukov/e33d580f701019e0cd99429054ff1f9a
Could you please include the full patch so that it can be discussed via email and such?
> Instrumentation will add for each function: > > static __always_inline void atomic64_set(atomic64_t *v, long long i) > { > + kasan_check_write(v, sizeof(*v)); > arch_atomic64_set(v, i); > }
That in itself looks sensible and readable.
Thanks,
Ingo
| ![\](/images/icornerr.gif) |