[lkml]   [2017]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mmc: core: Do not hold re-tuning during CMD6 commands

>> The retry mechanism provided by mmc_wait_for_cmd() and friends really only
>> makes sense for simple commands. In other cases, like this, we need to
>> consider what state the card is in. For __mmc_switch we need to consider
>> whether the card is busy or whether a timing change been made.
> I definitely agree. We should remove retries for CMD6 and perhaps also
> for some other cases.
> When we have changed the above in __mmc_switch(), the change Chaotian
> suggest gets a different impact, as it would potentially allow a
> re-tuning to happen before the next CMD1to poll for busy or to check


> the switch status. This isn't okay.
> This all sounds to me that Chaotian's issue may not all be related to
> tuning, but to the CMD6 switch sequence itself. However I may be wrong
> - of course. :-)
> [...]
> Kind regards
> Uffe

 \ /
  Last update: 2017-03-28 12:06    [W:0.057 / U:1.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site