[lkml]   [2017]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH v5 2/3] ARM: w90x900: let clk_disable() return immediately if clk is NULL
In many of clk_disable() implementations, it is a no-op for a NULL
pointer input, but this is one of the exceptions.

Making it treewide consistent will allow clock consumers to call
clk_disable() without NULL pointer check.

Signed-off-by: Masahiro Yamada <>
Acked-by: Wan Zongshun <>

Changes in v5: None
Changes in v4:
- Split into per-arch patches

Changes in v3:
- Return only when clk is NULL. Do not take care of error pointer.

Changes in v2:
- Rebase on Linux 4.6-rc1

arch/arm/mach-w90x900/clock.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-w90x900/clock.c b/arch/arm/mach-w90x900/clock.c
index 2c371ff..ac6fd1a 100644
--- a/arch/arm/mach-w90x900/clock.c
+++ b/arch/arm/mach-w90x900/clock.c
@@ -46,6 +46,9 @@ void clk_disable(struct clk *clk)
unsigned long flags;

+ if (!clk)
+ return;
WARN_ON(clk->enabled == 0);

spin_lock_irqsave(&clocks_lock, flags);
 \ /
  Last update: 2017-03-28 11:22    [W:0.052 / U:49.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site