lkml.org 
[lkml]   [2017]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH, net] isdn: kcapi: avoid uninitialized data
From
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 28 Mar 2017 12:11:07 +0200

> gcc-7 points out that the AVMB1_ADDCARD ioctl results in an unintialized
> value ending up in the cardnr parameter:
>
> drivers/isdn/capi/kcapi.c: In function 'old_capi_manufacturer':
> drivers/isdn/capi/kcapi.c:1042:24: error: 'cdef.cardnr' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> cparams.cardnr = cdef.cardnr;
>
> This has been broken since before the start of the git history, so
> either the value is not used for anything important, or the ioctl
> command doesn't get called in practice.
>
> Setting the cardnr to zero avoids the warning and makes sure
> we have consistent behavior.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied.

\
 
 \ /
  Last update: 2017-03-29 03:02    [W:0.087 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site