Messages in this thread | | | Date | Tue, 28 Mar 2017 20:18:15 +0200 | From | Peter Zijlstra <> | Subject | Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking trace event |
| |
On Tue, Mar 28, 2017 at 06:20:05PM +0100, Patrick Bellasi wrote: > On 28-Mar 18:57, Peter Zijlstra wrote: > > On Tue, Mar 28, 2017 at 06:44:59PM +0200, Peter Zijlstra wrote:
> > > +static int > > > +__update_load_avg(u64 now, int cpu, struct sched_avg *sa, > > > + unsigned long weight, int running, struct cfs_rq *cfs_rq) > > __attribute__((nonnull (6))); > > > > +{ > > > + return ___update_load_avg(now, cpu, sa, weight, running, cfs_rq); > > > > Although ideally we'd be able to tell the compiler that cfs_rq will not > > be NULL here. Hurmph.. no __builtin for that I think :/ > > What about the above attribute?
Ooh, shiny, thanks! My bad for failing to check the function attributes.
| |