lkml.org 
[lkml]   [2017]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] extcon: intel-cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver
From
Date
Hi,

On 24-03-17 05:38, Chanwoo Choi wrote:
> Hi,
>
> On 2017년 03월 24일 01:01, Hans de Goede wrote:
>> Add a driver for charger detection / control on the Intel Cherrytrail
>> Whiskey Cove PMIC.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> Changes in v2:
>> -Improve wait for charger detection loop, use jiffies to get an accurate timeout
>> -Sort registers by address, remove duplicate definition
>> -Return IRQ_NONE on interrupt handling errors
>> -Various small style cleanups
>> -Fix reporting no charger cable being present when detecting the same
>> charger type 2 times in a row
>> -Reset to autonomous / hw-mode on probe-error and on remove
>> Changes in v3:
>> -Add intel prefix to Kconfig symbol and filename
>> -Clarified "Unhandled charger type" warning msg
>> -Dropped usb_id sysfs attribute
>> ---
>> drivers/extcon/Kconfig | 7 +
>> drivers/extcon/Makefile | 1 +
>> drivers/extcon/extcon-intel-cht-wc.c | 352 +++++++++++++++++++++++++++++++++++
>> 3 files changed, 360 insertions(+)
>> create mode 100644 drivers/extcon/extcon-intel-cht-wc.c
>>
>
> Applied it on extcon-next branch.

Thank you.

Regards,

Hans


>
> [snip]
>
>> + usbsrc = (usbsrc & CHT_WC_USBSRC_TYPE_MASK) >> CHT_WC_USBSRC_TYPE_SHIFT;
>> + switch (usbsrc) {
>> + default:
>> + dev_warn(ext->dev, "Unhandled charger type %d, defaulting to SDP\n",
>
> Nit:
> This line is over length 80. So, I changed it as following
>
> dev_warn(ext->dev,
> "Unhandled charger type %d, defaulting to SDP\n",
>
>> + ret);
>> + /* Fall through, treat as SDP */
>> + case CHT_WC_USBSRC_TYPE_SDP:
>> + case CHT_WC_USBSRC_TYPE_FLOAT_DP_DN:
>> + case CHT_WC_USBSRC_TYPE_OTHER:
>> + return EXTCON_CHG_USB_SDP;
>> + case CHT_WC_USBSRC_TYPE_CDP:
>> + return EXTCON_CHG_USB_CDP;
>> + case CHT_WC_USBSRC_TYPE_DCP:
>> + case CHT_WC_USBSRC_TYPE_DCP_EXTPHY:
>> + case CHT_WC_USBSRC_TYPE_MHL: /* MHL2+ delivers upto 2A, treat as DCP */
>> + return EXTCON_CHG_USB_DCP;
>> + case CHT_WC_USBSRC_TYPE_ACA:
>> + return EXTCON_CHG_USB_ACA;
>> + }
>> +}
>

\
 
 \ /
  Last update: 2017-03-24 09:20    [W:0.048 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site