Messages in this thread | | | Date | Fri, 24 Mar 2017 15:02:15 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v2 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch |
| |
Hi Sean
> + regmap = devm_regmap_init(ds->dev, NULL, priv, > + &mt7530_regmap_config); > + if (IS_ERR(regmap)) > + dev_warn(priv->dev, "phy regmap initialization failed"); > +
Shouldn't this be a fatal error? If you keep going when there is an error, what happens when you actually try to use the regmap?
> + phy_mode = of_get_phy_mode(ds->ports[ds->dst->cpu_port].dn); > + if (phy_mode < 0) { > + dev_err(priv->dev, "Can't find phy-mode for master device\n"); > + return phy_mode; > + } > + dev_info(priv->dev, "phy-mode for master device = %x\n", phy_mode);
dev_dbg?
> + > + id = mt7530_read(priv, MT7530_CREV); > + id >>= CHIP_NAME_SHIFT; > + if (id != MT7530_ID) > + return -ENODEV;
It might be helpful to say what ID has been found, if it is not the supported ID.
Andrew
| |