lkml.org 
[lkml]   [2017]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] x86/mm/KASLR: EFI region is mistakenly included into KASLR VA space for randomization

* Dave Young <dyoung@redhat.com> wrote:

> > > So I applied this kexec fix and extended the changelog to clearly show why
> > > this fix matters in practice.
> >
> > I thought it only impacts kexec, but Dave thought it will impact 1st kenrel
> > either.
>
> Yes, I think no need to mention kexec, it is a general issue.
>
> First, the space is reserved for EFI, so kernel should not use it for kaslr.

It's the kernel's EFI code, and we map whatever address we want (and then pass
that to the EFI runtime), so wether it's randomized or not is the Linux kernel's
policy decision...

So that's my question: can these memory regions include security sensitive data,
and if yes, how can we best randomize it while kexec and other kernel and EFI
features still work?

Preserving virtual addresses for kexec is a red herring: the randomized offset
could be passed to the kexec-ed kernel just fine.

Thanks,

Ingo

\
 
 \ /
  Last update: 2017-03-24 10:25    [W:1.305 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site