Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 24 Mar 2017 12:07:57 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH 4/6] x86/kasan: Prepare clear_pgds() to switch to <asm-generic/pgtable-nop4d.h> |
| |
On Wed, Mar 22, 2017 at 08:31:36AM +0100, Ingo Molnar wrote: > * Andrey Ryabinin <aryabinin@virtuozzo.com> wrote: > > On 03/17/2017 09:55 PM, Kirill A. Shutemov wrote: > > > With folded p4d, pgd_clear() is nop. Change clear_pgds() to use > > > p4d_clear() instead. > > > > > > > You could probably just use set_pgd(pgd_offset_k(start), __pgd(0)); instead of pgd_clear() > > as we already do in arm64. > > It's basically pgd_clear() except it's not a nop wih p4d folded. > > Makes sense. Kirill, if you agree, mind spinning a v2 patch?
I can re-spin, if you want. But honestly, I don't think such constructs help readability.
-- Kirill A. Shutemov
| ![\](/images/icornerr.gif) |