lkml.org 
[lkml]   [2017]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] usb: gadget: Correct usb EP argument for BOT status request
    Date

    Hi,

    "Nicholas A. Bellinger" <nab@linux-iscsi.org> writes:
    > Hi Manish,
    >
    > (Added target-devel CC')
    >
    > On Mon, 2017-03-20 at 15:05 +0530, Manish Narani wrote:
    >> This patch corrects the argument in usb_ep_free_request as it is
    >> mistakenly set to ep_out. It should be ep_in for status request.
    >>
    >> Signed-off-by: Manish Narani <mnarani@xilinx.com>
    >> ---
    >> drivers/usb/gadget/function/f_tcm.c | 2 +-
    >> 1 files changed, 1 insertions(+), 1 deletions(-)
    >>
    >> diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
    >> index d235113..a82e2bd 100644
    >> --- a/drivers/usb/gadget/function/f_tcm.c
    >> +++ b/drivers/usb/gadget/function/f_tcm.c
    >> @@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu)
    >> usb_ep_free_request(fu->ep_in, fu->bot_req_in);
    >> usb_ep_free_request(fu->ep_out, fu->bot_req_out);
    >> usb_ep_free_request(fu->ep_out, fu->cmd.req);
    >> - usb_ep_free_request(fu->ep_out, fu->bot_status.req);
    >> + usb_ep_free_request(fu->ep_in, fu->bot_status.req);
    >>
    >> kfree(fu->cmd.buf);
    >>
    >
    > Applied to target-pending/master.

    Oh, so you're taking patches for f_tcm? Fair enough:

    Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>

    --
    balbi
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2017-03-22 10:38    [W:6.533 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site