lkml.org 
[lkml]   [2017]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/6 v3] ftrace/x86: Use Makefile logic instead of #ifdef of compling ftrace_*.o
On Mon, 20 Mar 2017 09:04:25 -0500
Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> On Sat, Mar 18, 2017 at 05:09:29PM -0400, Steven Rostedt wrote:
> > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> >
> > Currently ftrace_32.S and ftrace_64.S are compiled even when
> > CONFIG_FUNCTION_TRACER is not set. This means there's an
> > unnecessary #ifdef to protect the code. Instead of using
> > preprocessor directives, only compile those files when
> > FUNCTION_TRACER is defined.
> >
> > Link:
> > http://lkml.kernel.org/r/20170316210043.peycxdxktwwn6cid@treble
> > Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com> Signed-off-by:
> > Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> The subject has a typo ("compling") and would parse better if the
> second "of" where changed to a "for": "for compiling". Otherwise:

But this was to comply with #ifdef of ftrace_*.o!

;-)

>
> Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
>

Thanks!

-- Steve

\
 
 \ /
  Last update: 2017-03-22 01:57    [W:0.032 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site