Messages in this thread | | | From | Doug Anderson <> | Date | Mon, 20 Mar 2017 11:03:51 -0700 | Subject | Re: [PATCH v3] usb: hub: Fix error loop seen after hub communication errors |
| |
Hi,
On Thu, Mar 16, 2017 at 12:24 PM, Guenter Roeck <linux@roeck-us.net> wrote: > @@ -1198,7 +1201,7 @@ static void hub_activate(struct usb_hub *hub, enum hub_activation_type type) > > /* Scan all ports that need attention */ > kick_hub_wq(hub); > - > +abort:
One tiny nit that could be done when applying this patch is to add a space before "abort". Other goto labels in this function are preceded by a space and it's sane to try to match the existing coding convention in the function rather than trying to mix and match.
Other than that this patch seems sane to me, but I am by no means an expert on this code. ;)
-Doug
| |