Messages in this thread | | | Date | Tue, 21 Mar 2017 02:35:17 +1000 | From | Nicholas Piggin <> | Subject | Re: [v2 PATCH 1/4] powernv: Move CPU-Offline idle state invocation from smp.c to idle.c |
| |
On Mon, 20 Mar 2017 21:24:15 +0530 "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> wrote:
> From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> > > Move the piece of code in powernv/smp.c::pnv_smp_cpu_kill_self() which > transitions the CPU to the deepest available platform idle state to a > new function named pnv_cpu_offline() in powernv/idle.c. The rationale > behind this code movement is that the data required to determine the > deepest available platform state resides in powernv/idle.c. > > Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
Looks good. As a nitpick, possibly one or two variables in idle.c could become static (pnv_deepest_stop_psscr_*).
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
| |