Messages in this thread | | | Subject | Re: [PATCH v10 2/2] media: i2c: Add support for OV5647 sensor. | From | Vladimir Zapolskiy <> | Date | Mon, 20 Mar 2017 16:16:12 +0200 |
| |
Hi Ramiro,
On 03/06/2017 01:16 PM, Ramiro Oliveira wrote: > The OV5647 sensor from Omnivision supports up to 2592x1944 @ 15 fps, RAW 8 > and RAW 10 output formats, and MIPI CSI-2 interface. > > The driver adds support for 640x480 RAW 8. > > Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
All updates are fine, thank you. Feel free to add my
Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
> --- > MAINTAINERS | 7 + > drivers/media/i2c/Kconfig | 11 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/ov5647.c | 636 +++++++++++++++++++++++++++++++++++++++++++++
I see this version has 100 LoC less in comparison to v8, good result.
[snip]
> + > +static const struct v4l2_subdev_pad_ops ov5647_subdev_pad_ops = { > + .enum_mbus_code = ov5647_enum_mbus_code,
Nitpicking, above it's better to swap tab and space symbols around '='.
> +}; > + > +static const struct v4l2_subdev_ops ov5647_subdev_ops = { > + .core = &ov5647_subdev_core_ops, > + .video = &ov5647_subdev_video_ops, > + .pad = &ov5647_subdev_pad_ops, > +}; > +
-- With best wishes, Vladimir
| |