lkml.org 
[lkml]   [2017]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/6] x86: 5-level paging enabling for v4.12, Part 1
On Tue, Mar 14, 2017 at 10:48:51AM -0700, Linus Torvalds wrote:
> On Tue, Mar 14, 2017 at 12:47 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > I've also applied the GUP patch, with the assumption that you'll address Linus's
> > request to switch x86 over to the generic version.
>
> Note that switching over to the generic version is somewhat fraught
> with subtle issues:
>
> (a) we need to make sure that x86 actually matches the required
> semantics for the generic GUP.
>
> (b) we need to make sure the atomicity of the page table reads is ok.
>
> (c) need to verify the maximum VM address properly

There's another difference with generic version: it uses
page_cache_get_speculative() instead of plain get_page() on x86.
That's somewhat more expensive, but probably fine.

--
Kirill A. Shutemov

\
 
 \ /
  Last update: 2017-03-18 18:01    [W:0.078 / U:3.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site