lkml.org 
[lkml]   [2017]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[tip:x86/microcode] x86/microcode/AMD: Remove redundant NULL check on mc
Commit-ID:  cf8178f78645148dc38b28263b9d3f604148e3a8
Gitweb: http://git.kernel.org/tip/cf8178f78645148dc38b28263b9d3f604148e3a8
Author: Colin Ian King <colin.king@canonical.com>
AuthorDate: Wed, 15 Mar 2017 17:10:10 +0000
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sat, 18 Mar 2017 12:31:58 +0100

x86/microcode/AMD: Remove redundant NULL check on mc

mc is a pointer to the static u8 array amd_ucode_patch and
therefore can never be null, so the check is redundant. Remove it.

Detected by CoverityScan, CID#1372871 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: kernel-janitors@vger.kernel.org
Cc: x86-ml <x86@kernel.org>
Link: http://lkml.kernel.org/r/20170315171010.17536-1-colin.king@canonical.com
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/cpu/microcode/amd.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c
index 7889ae4..1d38e53 100644
--- a/arch/x86/kernel/cpu/microcode/amd.c
+++ b/arch/x86/kernel/cpu/microcode/amd.c
@@ -352,8 +352,6 @@ void reload_ucode_amd(void)
u32 rev, dummy;

mc = (struct microcode_amd *)amd_ucode_patch;
- if (!mc)
- return;

rdmsr(MSR_AMD64_PATCH_LEVEL, rev, dummy);

\
 
 \ /
  Last update: 2017-03-18 16:46    [W:0.057 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site