lkml.org 
[lkml]   [2017]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t
From
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sun, 19 Mar 2017 00:47:59 +0800

> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> On Fri, 2017-03-17 at 07:42 +0000, Reshetova, Elena wrote:
>>
>>> Should we then first measure the actual numbers to understand what we
>>> are talking here about?
>>> I would be glad to do it if you suggest what is the correct way to do
>>> measurements here to actually reflect the real life use cases.
>>
>> How have these patches been tested in real life exactly ?
>>
>> Can you quantify number of added cycles per TCP packet, where I expect
>> we have maybe 20 atomic operations in all layers ...
>
> I completely agree. I think this thing needs to default to the
> existing atomic_t behaviour.

I totally agree as well, the refcount_t facility as-is is unacceptable
for networking.

\
 
 \ /
  Last update: 2017-03-19 02:32    [W:0.092 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site