lkml.org 
[lkml]   [2017]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t
Date
> From: Kees Cook <keescook@chromium.org>
> Date: Thu, 16 Mar 2017 11:38:25 -0600
>
> > I am, of course, biased, but I think the evidence of actual
> > refcounting attacks outweighs the theoretical performance cost of
> > these changes.
>
> This is not theoretical at all.
>
> We count the nanoseconds that every packet takes to get processed and
> you are adding quite a bit.
>
> I understand your point of view, but this is knowingly going to add
> performance regressions to the networking code.

Should we then first measure the actual numbers to understand what we are talking here about?
I would be glad to do it if you suggest what is the correct way to do measurements here to actually reflect the real life use cases.

Best Regards,
Elena.

\
 
 \ /
  Last update: 2017-03-17 08:43    [W:0.076 / U:19.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site