Messages in this thread | | | Subject | Re: [PATCH linux v4 1/2] Documentation: dt-bindings: Document bindings for ASPEED AST2400/AST2500 PWM and Fan tach controller device driver | From | David Müller (ELSOFT AG) <> | Date | Thu, 16 Mar 2017 09:05:31 +0100 |
| |
Hello
Jaghathiswari Rankappagounder Natarajan wrote:
> +- compatible : should be "aspeed,aspeed2400-pwm-tacho" for AST2400 > or + "aspeed,aspeed2500-pwm-tacho" for AST2500.
Shouldn't this be "aspeed,ast2400-pwm-tacho" and "aspeed,ast2500-pwm-tacho", as this is the naming scheme used for all the other AST2x00 devices currently present in "aspeed-g[45].dtsi"?
Dave
| |