lkml.org 
[lkml]   [2017]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf, tools, script: Add brstackinsn for branch stacks
> > +	memset(&al, 0, sizeof(al));
> > + if (end - start > MAXBB - MAXINSN) {
> > + if (last)
> > + printf("\tbrstack does not reach to final jump (%" PRIx64 "-%" PRIx64 ")\n",
> > + start, end);
> > + else
> > + printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n",

Thanks. Should be %" PRIu64 " of course.

Arnaldo, can you do the change or should I send a patch?

-Andi

> > + start, end, end - start);
>
> This looks to be breaking the build on ppc64:
>
> builtin-script.c: In function ‘grab_bb’:
> builtin-script.c:595:11: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘u64 {aka long long unsigned int}’ [-Werror=format=]
> printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n", start, end, end - start);
> ^
>
> cheers
>

\
 
 \ /
  Last update: 2017-03-16 03:23    [W:0.138 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site