Messages in this thread | | | Date | Wed, 15 Mar 2017 19:22:18 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH] perf, tools, script: Add brstackinsn for branch stacks |
| |
> > + memset(&al, 0, sizeof(al)); > > + if (end - start > MAXBB - MAXINSN) { > > + if (last) > > + printf("\tbrstack does not reach to final jump (%" PRIx64 "-%" PRIx64 ")\n", > > + start, end); > > + else > > + printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n",
Thanks. Should be %" PRIu64 " of course.
Arnaldo, can you do the change or should I send a patch?
-Andi
> > + start, end, end - start); > > This looks to be breaking the build on ppc64: > > builtin-script.c: In function ‘grab_bb’: > builtin-script.c:595:11: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘u64 {aka long long unsigned int}’ [-Werror=format=] > printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n", start, end, end - start); > ^ > > cheers >
| |