lkml.org 
[lkml]   [2017]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/4] iio: accel: adxl345: Add support for triggered buffer
From
Date
On 13/03/17 12:16, Andy Shevchenko wrote:
> On Mon, Mar 13, 2017 at 1:11 PM, Eva Rachel Retuya <eraretuya@gmail.com> wrote:
>> Provide an all-axes read for triggered buffering.
>
> Better description is needed.
>
>> -static int adxl345_get_triple(struct adxl345_data *data, void *buf)
>> +static int adxl345_get_triple(struct adxl345_data *data)
>
> Ping-ponging again. This should be essentially a change in the patch
> where you introduce a helper.
>
>> +err_buffer_cleanup:
>> + iio_triggered_buffer_cleanup(indio_dev);
>> err_trigger_unregister:
>> if (data->drdy_trig)
>> iio_trigger_unregister(data->drdy_trig);
>
> devm_iio_*() ?
>
>> @@ -334,6 +435,7 @@ int adxl345_core_remove(struct device *dev)
>> struct adxl345_data *data = iio_priv(indio_dev);
>>
>> iio_device_unregister(indio_dev);
>> + iio_triggered_buffer_cleanup(indio_dev);
>> if (data->drdy_trig)
>> iio_trigger_unregister(data->drdy_trig);
>
> Ditto.
>
>> diff --git a/drivers/iio/accel/adxl345_i2c.c b/drivers/iio/accel/adxl345_i2c.c
>> index 8c791b8..1e0f071 100644
>> --- a/drivers/iio/accel/adxl345_i2c.c
>> +++ b/drivers/iio/accel/adxl345_i2c.c
>> @@ -30,6 +30,10 @@ static int adxl345_i2c_probe(struct i2c_client *client,
>> bool use_int2 = false;
>> int irq;
>>
>> + if (!i2c_check_functionality(client->adapter,
>> + I2C_FUNC_SMBUS_READ_I2C_BLOCK))
>> + return -EOPNOTSUPP;
>
> And if driver works before, you make a regression here.
Absolutely. Need a fallback if it's not supported...

Jonathan
>

\
 
 \ /
  Last update: 2017-03-15 22:50    [W:0.061 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site