lkml.org 
[lkml]   [2017]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v14 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD
Hi Ksenija,

> Lee Jones <lee.jones@linaro.org> hat am 14. März 2017 um 12:05 geschrieben:
>
>
> On Wed, 01 Mar 2017, Dmitry Torokhov wrote:
>
> > On Wed, Mar 01, 2017 at 09:10:50PM +0100, Stefan Wahren wrote:

...

> > >
> > > Since touchscreen is optional it doesn't make to try to register it, notice in the touchscreen driver there is no touchscreen, give the user a confusing error and finally disable the clock.
> > >
> > > Here are my suggestions:
> > >
> > > 1) Use the solution from Patch V6 but with an explaining comment that touchscreen is optional
> > >
> > > if (!lradc->touchscreen_wire)
> > > return 0;
> > >
> > > 2) Return a special error from touchscreen registration so mfd knowns this result is expected.
> > >
> > > I'm open for better solutions.
> > >
> > > @Lee: What's your opinion?
> >
> > I am not Lee, but given that this module already parses touchscreen
> > properties and knows whether there is touchscreen or not, #1 seems
> > simple and logical.
>
> Sorry for the delay, I'm currently behind on my mail due to vacation
> and conferences.
>
> +1
>

could you please submit a V15? It would be great to get this into 4.12.

Thanks
Stefan

\
 
 \ /
  Last update: 2017-03-15 22:18    [W:0.344 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site