lkml.org 
[lkml]   [2017]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 3/8] staging: rtl8192e: Remove unnecessary 'out of memory' message
    Date
    From: Suniel Mahesh <sunil.m@techveda.org>

    Fixed the following checkpatch.pl warning:
    Possible unnecessary 'out of memory' message
    If it is out of memory, function should return with an
    appropriate error code. Since this function is of type void,
    a return statement is used.

    Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
    ---
    Changes for v4:

    - Modified description for better readability as pointed out by
    Dan Carpenter

    Changes for v3:

    - Split earlier patches into multiple commits for easy review
    as suggested by Greg K-H
    - Modified subject and description for better readability
    - Rebased on top of next-20170310
    - Patches were tested and built on next-20170310 and staging-testing
    as suggested by Greg K-H, no errors reported

    Changes for v2:

    - Improve error handling reported by checkpatch.pl in rtl_core.c
    - new patch addition to the series
    - Rebased on top of next-20170306
    ---
    drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
    index eb2321c..37a03ca 100644
    --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
    +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
    @@ -971,8 +971,8 @@ static void _rtl92e_init_priv_variable(struct net_device *dev)

    priv->pFirmware = vzalloc(sizeof(struct rt_firmware));
    if (!priv->pFirmware)
    - netdev_err(dev,
    - "rtl8192e: Unable to allocate space for firmware\n");
    + return;
    +
    skb_queue_head_init(&priv->skb_queue);

    for (i = 0; i < MAX_QUEUE_SIZE; i++)
    --
    1.9.1
    \
     
     \ /
      Last update: 2017-03-15 12:00    [W:6.531 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site